ferenc-csaky commented on code in PR #26723:
URL: https://github.com/apache/flink/pull/26723#discussion_r2174720397
##########
.github/workflows/community-review.sh:
##########
@@ -208,34 +208,34 @@ process_pr_reviews() {
#see if the user has read role
- if [ "$push_permission" = 'true' ]; then
- if [ "$state" = "APPROVED" ]; then
+ if [[ "$push_permission" == "true" ]]; then
+ if [[ "$state" == "APPROVED" ]]; then
((++committerApproves))
fi
else
((++communityReviews))
- if [ "$state" = "APPROVED" ]; then
+ if [[ "$state" == "APPROVED" ]]; then
((++communityApproves))
fi
fi
- if [ "$state" = "CHANGES_REQUESTED" ]; then
+ if [[ "$state" == "CHANGES_REQUESTED" ]]; then
((++requestForChanges))
fi
done <<< "$pr_reviews"
echo "communityApproves $communityApproves requestForChanges
$requestForChanges committerApproves $committerApproves communityReviews
$communityReviews"
local label_to_post=
local label_to_delete=
- if [[ $communityApproves -ge "2" && $requestForChanges = 0 &&
$committerApproves = 0 ]]; then
+ if [[ $communityApproves -ge 2 && $requestForChanges = 0 &&
$committerApproves = 0 ]]; then
Review Comment:
Let's update all 3 parts of the condition to use arithmetic operators:
```bash
[[ $communityApproves -ge 2 && $requestForChanges -eq 0 &&
$committerApproves -eq 0 ]]
```
Also there is an extra whitespace at `-ge 2` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
