davidradl commented on code in PR #26743:
URL: https://github.com/apache/flink/pull/26743#discussion_r2180978427
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java:
##########
@@ -214,9 +214,11 @@ public ClusterClientProvider<String>
deployApplicationCluster(
applicationConfiguration.applyToConfiguration(flinkConfig);
- // No need to do pipelineJars validation if it is a PyFlink job.
+ // No need to do pipelineJars validation if it is a PyFlink job or
using system classpath.
if
(!(PackagedProgramUtils.isPython(applicationConfiguration.getApplicationClassName())
- ||
PackagedProgramUtils.isPython(applicationConfiguration.getProgramArguments())))
{
+ || PackagedProgramUtils.isPython(
+
applicationConfiguration.getProgramArguments()))
+ && !PackagedProgramUtils.usingSystemClassPath(flinkConfig)) {
Review Comment:
the comment says `or using system classpath.` but the code says and `&&
!PackagedProgramUtils.usingSystemClassPath(flinkConfig)) ` .
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java:
##########
@@ -214,9 +214,11 @@ public ClusterClientProvider<String>
deployApplicationCluster(
applicationConfiguration.applyToConfiguration(flinkConfig);
- // No need to do pipelineJars validation if it is a PyFlink job.
+ // No need to do pipelineJars validation if it is a PyFlink job or
using system classpath.
if
(!(PackagedProgramUtils.isPython(applicationConfiguration.getApplicationClassName())
- ||
PackagedProgramUtils.isPython(applicationConfiguration.getProgramArguments())))
{
+ || PackagedProgramUtils.isPython(
+
applicationConfiguration.getProgramArguments()))
+ && !PackagedProgramUtils.usingSystemClassPath(flinkConfig)) {
Review Comment:
the comment says `or using system classpath.` but the code says and `&&
!PackagedProgramUtils.usingSystemClassPath(flinkConfig)) ` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
