Zakelly commented on code in PR #26744:
URL: https://github.com/apache/flink/pull/26744#discussion_r2182249865


##########
docs/content.zh/docs/ops/metrics.md:
##########
@@ -1181,6 +1181,11 @@ Note that for failed checkpoints, metrics are updated on 
a best efforts basis an
       <td>The full size of the last checkpoint (in bytes).</td>
       <td>Gauge</td>
     </tr>
+    <tr>
+      <td>lastCheckpointMetadataSize</td>
+      <td>上次检查点 _metadata 文件的大小(字节).</td>

Review Comment:
   Well, we can keep English here since this page has not been translated to 
Chinese yet.



##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/AbstractCheckpointStats.java:
##########
@@ -93,6 +93,13 @@ public abstract class AbstractCheckpointStats implements 
Serializable {
      */
     public abstract long getCheckpointedSize();
 
+    /**
+     * @return The metadata file size, 0 if unknown.
+     */
+    public long getMetadataSize() {

Review Comment:
   better keep this method abstract



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to