davidradl commented on code in PR #26745:
URL: https://github.com/apache/flink/pull/26745#discussion_r2183114419
##########
.github/workflows/community-review.sh:
##########
@@ -202,31 +200,31 @@ process_pr_reviews() {
while IFS=, read -r user state time
do
- printf "%-15s | %-20s | %-20s - checking user permissions..." "$user"
"$state" "$time"
- push_permission=$(call_github_get_user_push_permission "$token" "$user")
|| exit
- printf "%s\n" "$push_permission"
-
- #see if the user has read role
-
- if [[ "$push_permission" == "true" ]]; then
- if [[ "$state" == "APPROVED" ]]; then
- ((++committerApproves))
- fi
- else
- ((++communityReviews))
- if [[ "$state" == "APPROVED" ]]; then
- ((++communityApproves))
- fi
- fi
-
- if [[ "$state" == "CHANGES_REQUESTED" ]]; then
- ((++requestForChanges))
- fi
+ printf "%-15s | %-20s | %-20s - checking user permissions..." "$user"
"$state" "$time"
+ push_permission=$(call_github_get_user_push_permission "$token" "$user")
|| exit
+ printf "%s\n" "$push_permission"
+
+ #see if the user has read role
+ if [[ "$push_permission" == "true" ]]; then
+ if [[ "$state" == "APPROVED" ]]; then
+ ((++committerApproves))
+ fi
+ else
+ ((++communityReviews))
+ if [[ "$state" == "APPROVED" ]]; then
+ ((++communityApproves))
+ fi
+ fi
+
+ if [[ "$state" == "CHANGES_REQUESTED" ]]; then
+ ((++requestForChanges))
+ fi
done <<< "$pr_reviews"
echo "communityApproves $communityApproves requestForChanges
$requestForChanges committerApproves $committerApproves communityReviews
$communityReviews"
local label_to_post=
local label_to_delete=
+ local existing_labels
Review Comment:
nit:existing_labels initialized differently to the 2 previous variables
which have = . Maybe make them the same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
