PatrickRen commented on PR #45: URL: https://github.com/apache/flink-agents/pull/45#issuecomment-3033446771
Hi @wenjin272 @codenohup Thanks a lot for the review! As suggested by @wenjin272 , I changed checkSignature in PythonFunction to do nothing, and updated related tests. @codenohup > but I encountered a non-serializable exception with WorkflowPlan. Well I think it depends on which serialization style we should use for `WorkflowPlan`: Java object serialization or JSON serialization. If we want to use the Java object serialization way, we need to mark `WorkflowPlan` as `Serializable` as you suggested, but we also need to mark `Action` as `Serializable`, then `Function` also should be `Serializable`, which is a bit difficult to enforce it. So maybe it’s more reasonable to use the JSON serde as replied by @wenjin272 . > Should we also consider adding a context parameter to support sending events and updating state? This is a good idea, but as @wenjin said I didn’t find Java implementation of the context, so it’s better to have a followup PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
