leonardBang commented on code in PR #4053: URL: https://github.com/apache/flink-cdc/pull/4053#discussion_r2189351013
########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/src/test/resources/log4j2-test.properties: ########## @@ -0,0 +1,25 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# http://www.apache.org/licenses/LICENSE-2.0 +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +# Set root logger level to ERROR to not flood build logs +# set manually to INFO for debugging purposes +rootLogger.level=WARN Review Comment: change to `OFF ` to match with other modules ########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/pom.xml: ########## @@ -0,0 +1,139 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-cdc-pipeline-connectors</artifactId> + <version>${revision}</version> + </parent> + + <artifactId>flink-cdc-pipeline-connector-fluss</artifactId> + <packaging>jar</packaging> + + <name>flink-cdc-pipeline-connector-fluss</name> + <url>http://maven.apache.org</url> + + + <properties> + <fluss.version>0.7.0</fluss.version> + </properties> + + <dependencies> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-client</artifactId> + <version>${fluss.version}</version> + </dependency> + + + <!-- Test dependencies --> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-cdc-composer</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-test-utils</artifactId> + <version>${flink.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-server</artifactId> + <version>${fluss.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-server</artifactId> + <version>${fluss.version}</version> + <type>test-jar</type> + <scope>test</scope> + </dependency> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-test-utils</artifactId> + <version>${fluss.version}</version> + <scope>test</scope> + </dependency> + <!-- In cdc yaml, we use our own sink. Thus, import fluss-fink just for test --> Review Comment: <!-- In Flink CDC project has Pipeline Sink Connector for Fluss. we import fluss-fink for Fluss Sink Connector just for test purpose --> ########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/pom.xml: ########## @@ -0,0 +1,139 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-cdc-pipeline-connectors</artifactId> + <version>${revision}</version> + </parent> + + <artifactId>flink-cdc-pipeline-connector-fluss</artifactId> + <packaging>jar</packaging> + + <name>flink-cdc-pipeline-connector-fluss</name> + <url>http://maven.apache.org</url> + + + <properties> + <fluss.version>0.7.0</fluss.version> + </properties> + + <dependencies> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-client</artifactId> + <version>${fluss.version}</version> + </dependency> + + + <!-- Test dependencies --> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-cdc-composer</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-test-utils</artifactId> + <version>${flink.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-server</artifactId> + <version>${fluss.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-server</artifactId> + <version>${fluss.version}</version> + <type>test-jar</type> + <scope>test</scope> + </dependency> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-test-utils</artifactId> + <version>${fluss.version}</version> + <scope>test</scope> + </dependency> + <!-- In cdc yaml, we use our own sink. Thus, import fluss-fink just for test --> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-flink-common</artifactId> + <version>${fluss.version}</version> + <type>test-jar</type> + <scope>test</scope> + </dependency> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-flink-1.20</artifactId> + <version>${fluss.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table-planner_2.12</artifactId> + <version>${flink.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-cdc-pipeline-connector-values</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + + + + </dependencies> + + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-shade-plugin</artifactId> + <version>${maven.shade.plugin.version}</version> + <executions> + <execution> + <id>shade-flink</id> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <shadeTestJar>false</shadeTestJar> + <artifactSet> + <includes> + <include>com.alibaba.fluss:*</include> + </includes> Review Comment: only include fluss dependency is enough? Do we need to shade common dependencies which are easy to conflict? ########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/pom.xml: ########## @@ -0,0 +1,139 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- +Licensed to the Apache Software Foundation (ASF) under one or more +contributor license agreements. See the NOTICE file distributed with +this work for additional information regarding copyright ownership. +The ASF licenses this file to You under the Apache License, Version 2.0 +(the "License"); you may not use this file except in compliance with +the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + <parent> + <groupId>org.apache.flink</groupId> + <artifactId>flink-cdc-pipeline-connectors</artifactId> + <version>${revision}</version> + </parent> + + <artifactId>flink-cdc-pipeline-connector-fluss</artifactId> + <packaging>jar</packaging> + + <name>flink-cdc-pipeline-connector-fluss</name> + <url>http://maven.apache.org</url> + + + <properties> + <fluss.version>0.7.0</fluss.version> + </properties> + + <dependencies> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-client</artifactId> + <version>${fluss.version}</version> + </dependency> + + + <!-- Test dependencies --> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-cdc-composer</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-test-utils</artifactId> + <version>${flink.version}</version> + <scope>test</scope> + </dependency> + + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-server</artifactId> + <version>${fluss.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-server</artifactId> + <version>${fluss.version}</version> + <type>test-jar</type> + <scope>test</scope> + </dependency> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-test-utils</artifactId> + <version>${fluss.version}</version> + <scope>test</scope> + </dependency> + <!-- In cdc yaml, we use our own sink. Thus, import fluss-fink just for test --> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-flink-common</artifactId> + <version>${fluss.version}</version> + <type>test-jar</type> + <scope>test</scope> + </dependency> + <dependency> + <groupId>com.alibaba.fluss</groupId> + <artifactId>fluss-flink-1.20</artifactId> + <version>${fluss.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-table-planner_2.12</artifactId> + <version>${flink.version}</version> + <scope>test</scope> + </dependency> + <dependency> + <groupId>org.apache.flink</groupId> + <artifactId>flink-cdc-pipeline-connector-values</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + + + Review Comment: minor: remove blank lines ########## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/src/main/java/org/apache/flink/cdc/connectors/fluss/sink/v2/metrics/FlinkCounter.java: ########## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.cdc.connectors.fluss.sink.v2.metrics; + +import org.apache.flink.metrics.Counter; + +/* This file is based on source code of Apache Fluss Project (https://fluss.apache.org/), licensed by the Apache + * Software Foundation (ASF) under the Apache License, Version 2.0. See the NOTICE file distributed with this work for + * additional information regarding copyright ownership. */ + +/** An implementation of Flink's {@link Counter} which wraps Fluss's Counter. */ +public class FlinkCounter implements Counter { + + private final com.alibaba.fluss.metrics.Counter wrapped; + + public FlinkCounter(com.alibaba.fluss.metrics.Counter wrapped) { + this.wrapped = wrapped; + } Review Comment: ```suggestion public class WarppedFlussCounter implements Counter { private final com.alibaba.fluss.metrics.Counter flussCounter; public WarppedFlussCounter(com.alibaba.fluss.metrics.Counter flussCounter) { this.flussCounter = flussCounter; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
