lihaosky commented on code in PR #26770:
URL: https://github.com/apache/flink/pull/26770#discussion_r2195285084
##########
flink-dist/src/main/assemblies/bin.xml:
##########
@@ -122,6 +122,13 @@ under the License.
<fileMode>0644</fileMode>
</file>
+ <file>
Review Comment:
sql client won't work if this is reverted. There will be class not found
problem. It's easier to test by adding this here? But I'm not sure what's the
criteria to add connector here
##########
flink-dist/pom.xml:
##########
@@ -365,6 +365,13 @@ under the License.
<scope>provided</scope>
</dependency>
+ <dependency>
Review Comment:
QQ: looks file connector is here, when should be add connector or model
provider here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
