snuyanzin commented on code in PR #26547:
URL: https://github.com/apache/flink/pull/26547#discussion_r2201794672


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/AggregateCallJsonDeserializer.java:
##########
@@ -85,6 +85,7 @@ public AggregateCall deserialize(JsonParser jsonParser, 
DeserializationContext c
                 distinct,
                 approximate,
                 ignoreNulls,
+                new ArrayList<>(),

Review Comment:
   In commit which added this 
https://github.com/apache/calcite/commit/ddb4200f8f52b02afb1b866abb0785218e2c5994
   
   it is mentioned that it is 
   >These changes are in preparation for 
[[CALCITE-4334](https://issues.apache.org/jira/browse/CALCITE-4334)] 
LITERAL_AGG.
   
   I was not able to find any test using it...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to