dylanhz commented on code in PR #26771:
URL: https://github.com/apache/flink/pull/26771#discussion_r2203690664
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/MiscFunctionsITCase.java:
##########
@@ -229,6 +229,12 @@ Stream<TestSetSpec> getTestSetSpecs() {
lit("Hello world").encode($("f2")),
"ENCODE('Hello world', f2)",
"Hello world".getBytes(StandardCharsets.UTF_8),
+ DataTypes.BYTES().nullable())
+ .testResult(
+ // test for nullability of return type
+ lit("Hello world").encode("utf-8"),
+ "ENCODE('Hello world', 'utf-8')",
+ "Hello world".getBytes(StandardCharsets.UTF_8),
DataTypes.BYTES().nullable()),
Review Comment:
@snuyanzin
Hi, could you take a look at the comment? I think it's time to finish this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
