nishita-09 commented on code in PR #997:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/997#discussion_r2204738669
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/CommonStatus.java:
##########
@@ -90,6 +90,28 @@ public ResourceLifecycleState getLifecycleState() {
return ResourceLifecycleState.FAILED;
}
+ // Check for unrecoverable deployments that should be marked as FAILED
+ if (this instanceof FlinkDeploymentStatus) {
+ FlinkDeploymentStatus deploymentStatus = (FlinkDeploymentStatus)
this;
+ var jmDeployStatus =
deploymentStatus.getJobManagerDeploymentStatus();
+
+ // ERROR/MISSING deployments are in terminal error state
+ // [Configmaps deleted -> require manual restore] and should
always be FAILED
+ if ((jmDeployStatus == JobManagerDeploymentStatus.MISSING
+ || jmDeployStatus ==
JobManagerDeploymentStatus.ERROR)
+ && StringUtils.isNotEmpty(error)
+ && (error.toLowerCase()
+ .contains(
+ "it is possible that the job has
finished or terminally failed, or the configmaps have been deleted")
+ || error.toLowerCase().contains("manual restore
required")
+ || error.toLowerCase().contains("ha metadata not
available")
+ || error.toLowerCase()
+ .contains(
+ "ha data is not available to make
stateful upgrades"))) {
Review Comment:
@gyfora
1. There are multiple instances where `HA metadata not available` is written
in different forms like `HA metadata not available` and `HA data is not
available`. Should we maintain a uniformity in these by changing these
exception messages using a constant (now that it is available).
2. Also currently `flink-operator-api` does not have `flink-operator` as a
dependency -> to use the constants in `AbstractJobReconciler` we would have to
import it as a dependency as the status change logic resides in
`flink-operator-api`.
Should I still go ahead with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
