davidradl commented on code in PR #26803:
URL: https://github.com/apache/flink/pull/26803#discussion_r2213704057
##########
flink-python/src/main/java/org/apache/flink/client/python/PythonEnvUtils.java:
##########
@@ -368,11 +369,18 @@ static Process startPythonProcess(
// set the child process the output same as the parent process.
pythonProcessBuilder.redirectOutput(ProcessBuilder.Redirect.INHERIT);
}
-
LOG.info(
"Starting Python process with environment variables: {{}},
command: {}",
env.entrySet().stream()
- .map(e -> e.getKey() + "=" + e.getValue())
Review Comment:
Can we use the existing
[hideSensitiveValues](https://github.com/apache/flink/blob/2cd8a1428ce4e678ef546e0b22293c72c1bc9191/flink-core/src/main/java/org/apache/flink/configuration/ConfigurationUtils.java#L181)
method
##########
flink-python/src/main/java/org/apache/flink/client/python/PythonEnvUtils.java:
##########
@@ -368,11 +369,18 @@ static Process startPythonProcess(
// set the child process the output same as the parent process.
pythonProcessBuilder.redirectOutput(ProcessBuilder.Redirect.INHERIT);
}
-
LOG.info(
"Starting Python process with environment variables: {{}},
command: {}",
env.entrySet().stream()
- .map(e -> e.getKey() + "=" + e.getValue())
Review Comment:
Can we use the existing
[hideSensitiveValues](https://github.com/apache/flink/blob/2cd8a1428ce4e678ef546e0b22293c72c1bc9191/flink-core/src/main/java/org/apache/flink/configuration/ConfigurationUtils.java#L181)
method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
