davidradl commented on code in PR #26807:
URL: https://github.com/apache/flink/pull/26807#discussion_r2215590996
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/over/NonTimeRangeUnboundedPrecedingFunction.java:
##########
@@ -422,11 +422,13 @@ private Tuple2<Integer, Boolean> findIndexOfSortKey(
private void setAccumulatorOfPrevRow(
List<Tuple2<RowData, List<Long>>> sortedList, int prevIndex)
throws Exception {
if (prevIndex < 0) {
- aggFuncs.createAccumulators();
+ RowData accData = aggFuncs.createAccumulators();
+ aggFuncs.setAccumulators(accData);
Review Comment:
nit: another suggested style change - you do not need to implement this if
you don't want to.
```
RowData accumulator = accMapState.get(sortedList.get(prevIndex).f0);
if (accumulator == null) {
accumulator = aggFuncs.createAccumulators();
}
aggFuncs.setAccumulators(accumulator);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
