KeGu-069 commented on code in PR #67:
URL: https://github.com/apache/flink-agents/pull/67#discussion_r2218136890
##########
runtime/src/main/java/org/apache/flink/agents/runtime/python/context/PythonRunnerContextImpl.java:
##########
@@ -40,4 +47,9 @@ public void sendEvent(String type, byte[] event) {
// this method will be invoked by PythonActionExecutor's python
interpreter.
sendEvent(new PythonEvent(event, type));
}
+
+ @Override
Review Comment:
Event on the Python side lacks a specific type compared to the Java side, so
the interface and methods have new implementations. However, MemoryObject has
no difference on both sides, so this method can be implemented the same as the
parent class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]