codenohup commented on code in PR #80:
URL: https://github.com/apache/flink-agents/pull/80#discussion_r2239278569
##########
python/flink_agents/runtime/local_runner.py:
##########
@@ -115,6 +115,23 @@ def get_short_term_memory(self) -> MemoryObject:
"""
return self._short_term_memory
+ def execute_async(
+ self,
+ func: Callable[[Any], Any],
+ *args: Tuple[Any, ...],
+ **kwargs: Dict[str, Any],
+ ) -> Any:
+ """Asynchronously execute the provided function. Access to memory
+ is prohibited within the function.
+ """
+ logger.info(
+ "Local runner does not support asynchronous execution; falling
back to synchronous execution."
+ )
+ func_result = func(*args, **kwargs)
+ yield func_result
Review Comment:
> Why do we need this yeild here?
Since the user is using _yield from_ to await the result of an asynchronous
function in their _action_, we should also use yield to return the result of
the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
