Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2976#discussion_r94964350
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateReduceGroupFunction.scala
---
@@ -87,6 +90,17 @@ class AggregateReduceGroupFunction(
output.setField(after,
aggregates(previous).evaluate(aggregateBuffer))
}
+ // Evaluate grouping sets additional values
+ if (groupingSetsMapping != null && groupingSetsMapping.nonEmpty) {
+
+ val groupingFields = groupKeysMapping.map(_._1)
+ groupingSetsMapping.map {
--- End diff --
I would simplify these lines to one map instead of a map followed by
foreach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
