gustavodemorais commented on code in PR #26856:
URL: https://github.com/apache/flink/pull/26856#discussion_r2245416428
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-multi-join_1/four-way-complex-updating-join-with-restore/plan/four-way-complex-updating-join-with-restore.json:
##########
@@ -103,22 +103,31 @@
}
}
}
- }
+ },
+ "abilities" : [ {
+ "type" : "ProjectPushDown",
+ "projectedFields" : [ [ 0 ], [ 2 ] ],
+ "producedType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL,
`user_id_1` VARCHAR(2147483647)> NOT NULL"
+ }, {
+ "type" : "ReadingMetadata",
+ "metadataKeys" : [ ],
+ "producedType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL,
`user_id_1` VARCHAR(2147483647)> NOT NULL"
+ } ]
},
- "outputType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL, `product`
VARCHAR(2147483647), `user_id_1` VARCHAR(2147483647)>",
- "description" : "TableSourceScan(table=[[default_catalog,
default_database, Orders]], fields=[order_id, product, user_id_1])"
+ "outputType" : "ROW<`order_id` VARCHAR(2147483647) NOT NULL, `user_id_1`
VARCHAR(2147483647)>",
+ "description" : "TableSourceScan(table=[[default_catalog,
default_database, Orders, project=[order_id, user_id_1], metadata=[]]],
fields=[order_id, user_id_1])"
Review Comment:
Looked a bit into it and the metadata property is quite deep since it's hard
coded as part of the full qualified table property (table:
getQualifiedName->getSpecDigests->getDigests)
[here](https://github.com/apache/flink/blob/c0044be734a74353ddb9768f7559aaf27c04a1fa/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/ReadingMetadataSpec.java#L86).
Do you think it's worth creating a ticket and addressing this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
