1996fanrui commented on code in PR #1003:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1003#discussion_r2254230947
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -560,6 +560,12 @@ public Optional<Savepoint> getLastCheckpoint(JobID jobId,
Configuration conf) {
&& e.getMessage().contains("Checkpointing has not been
enabled")) {
LOG.warn("Checkpointing not enabled for job {}", jobId, e);
return Optional.empty();
+ } else if (e instanceof ExecutionException
+ && e.getMessage() != null
+ && e.getMessage()
+ .contains(String.format("Job %s not found",
jobId.toString()))) {
+ LOG.warn("Job {} not found", jobId, e);
Review Comment:
Thanks @qinf for the PR.
I'm not sure if "Job %s not found" means the job is finished. Is it possible
that the job failed?
Or could you please add some background in PR description to explain what
the relationship is between `getLastCheckpoint` and clean job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
