gustavodemorais commented on code in PR #26894:
URL: https://github.com/apache/flink/pull/26894#discussion_r2269812448


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/MultiJoinSemanticTests.java:
##########
@@ -26,6 +28,14 @@
 /** Semantic tests for {@link StreamExecMultiJoin}. */
 public class MultiJoinSemanticTests extends SemanticTestBase {
 
+    @Override
+    protected void envDefaultOptions(TableEnvironment env) {
+        env.getConfig()
+                .set(
+                        
OptimizerConfigOptions.TABLE_OPTIMIZER_NONDETERMINISTIC_UPDATE_STRATEGY,

Review Comment:
   I think this is a good idea. However, I think we need other unrelated 
changes to enable it, including PTFs. Tried it quickly and 
   
   ```
   java.lang.UnsupportedOperationException: Unsupported to visit node 
StreamPhysicalProcessTableFunction, please add the visit implementation if it 
is a newly added stream physical node.
   ```
   
   So I'd suggest for us to do it in a next PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to