snuyanzin commented on code in PR #26893:
URL: https://github.com/apache/flink/pull/26893#discussion_r2271394043
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecChangelogNormalize.java:
##########
@@ -166,9 +166,13 @@ protected Transformation<RowData> translateToPlanInternal(
new EqualiserCodeGenerator(inputType, classLoader)
.generateRecordEqualiser("DeduplicateRowEqualiser");
+ // Depending on whether filterCondition is null or not, there is
different logic
+ // at ProcTimeMiniBatchDeduplicateKeepLastRowFunction#finishBundle
final GeneratedFilterCondition generatedFilterCondition =
- FilterCodeGenerator.generateFilterCondition(
- config, classLoader, filterCondition, inputType);
+ filterCondition == null
+ ? null
+ : FilterCodeGenerator.generateFilterCondition(
+ config, classLoader, filterCondition,
inputType);
Review Comment:
it looks like we can skip generation and execution of filter condition in
this case
also, without this change
`DeduplicateFunctionHelper#processLastRowOnChangelog` was never called.
It just always called
`DeduplicateFunctionHelper#processLastRowOnChangelogWithFilter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
