xuyangzhong commented on code in PR #26381:
URL: https://github.com/apache/flink/pull/26381#discussion_r2275688849
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/calcite/Sink.scala:
##########
@@ -42,7 +42,8 @@ import scala.collection.JavaConversions._
* @param hints
* the hints
* @param targetColumns
- * the specified target columns.
+ * the specified target columns. @Deprecated(since = "2.2"), use
Review Comment:
```
the specified target columns. This field has been deprecated as part of
FLIP-506 since 2.2. Please use
* [[TargetColumnWritingSpec]] in [[abilitySpecs]] instead.
```
Additionally, we should move all `abilitySpecs` from all the `Sink`
subclasses up into the `Sink` base class. When a feature on the `Sink` is
deprecated, we can provide a direct, compatible replacement for it.
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java:
##########
@@ -756,6 +763,8 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
final Map<String, DataType> writableMetadata =
convertToMetadataMap(
helper.getOptions().get(WRITABLE_METADATA),
context.getClassLoader());
+ final int[][] targetColumns =
Review Comment:
Why do we get the target columns by table options instead of using
`SupportsTargetColumnWriting`?
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/sink/DynamicTableSink.java:
##########
@@ -190,7 +190,11 @@ interface Context {
* </ul>
*
* <p>Note: will always return empty for the delete statement because
it has no column list.
+ *
+ * @deprecated use {@link
+ *
org.apache.flink.table.connector.sink.abilities.SupportsTargetColumnWriting}
instead.
Review Comment:
nit: import this class instead of using the whole package path in comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
