michalstutzmann commented on code in PR #26895:
URL: https://github.com/apache/flink/pull/26895#discussion_r2280257439
##########
flink-table/pom.xml:
##########
@@ -78,8 +78,8 @@ under the License.
</dependencyManagement>
<properties>
- <calcite.version>1.36.0</calcite.version>
- <!-- Calcite 1.36.0 depends on 3.1.9,
+ <calcite.version>1.37.0</calcite.version>
+ <!-- Calcite 1.37.0 depends on 3.1.9,
Review Comment:
Janino 3.1.11 has changed the way the compiler factory is loaded - has
[switched to Java's
`ServiceLoader.`](https://github.com/janino-compiler/janino/issues/209) The e2e
tests were failing due class loading issues - the
[META-INF/services](https://github.com/janino-compiler/janino/blob/3.1.11/commons-compiler-jdk/src/main/resources/META-INF/services/org.codehaus.commons.compiler.ICompilerFactory)
from Janino's jar could not be found by `ServiceLoader`. Adding the entry to
[table planner's
jar](https://github.com/apache/flink/pull/26895/commits/64ead2bc1973ce0223fad48b34c6a274d3c06fba)
resolves the issue. This is the simplest solution I've found so far. Have
upgraded Janino to the latest patch version 3.1.12.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
