csviri commented on code in PR #1013:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1013#discussion_r2287415790
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesScalingRealizer.java:
##########
@@ -63,15 +62,16 @@ public void realizeConfigOverrides(
}
FlinkDeployment flinkDeployment = ((FlinkDeployment)
context.getResource());
// Apply config overrides
- Map<String, String> flinkConf =
flinkDeployment.getSpec().getFlinkConfiguration();
- for (String keyToRemove : configChanges.getRemovals()) {
- flinkConf.remove(keyToRemove);
- }
- flinkConf.putAll(configChanges.getOverrides());
+
+
flinkDeployment.getSpec().getFlinkConfiguration().remove(configChanges.getRemovals());
Review Comment:
actually this uses this method from jackson
```java
public ObjectNode remove(Collection<String> propertyNames) {
this._children.keySet().removeAll(propertyNames);
return this;
}
```
would rather rename our `removeAll` to `remove` so we follow this
convention/style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
