gaborgsomogyi commented on code in PR #26933:
URL: https://github.com/apache/flink/pull/26933#discussion_r2295403235


##########
flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/table/module/ExampleDynamicBuiltInFunctionDefinitionFactory.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.state.table.module;
+
+import org.apache.flink.table.functions.BuiltInFunctionDefinition;
+import 
org.apache.flink.table.functions.DynamicBuiltInFunctionDefinitionFactory;
+
+import java.util.List;
+
+public class ExampleDynamicBuiltInFunctionDefinitionFactory

Review Comment:
   This API is now fully experimental and later subject to change. If the time 
comes and `ModuleContext` or something else is required then we're going to add 
it. Finding out later needs is just not working in general 🙂
   Related the names there is already a builtin function name suggestion which 
already given. Of course this is not documented because it's not public API and 
I would stick to that since it exists from ages.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to