GreatEugenius commented on code in PR #122:
URL: https://github.com/apache/flink-agents/pull/122#discussion_r2300326914
##########
python/flink_agents/runtime/local_execution_environment.py:
##########
@@ -86,6 +88,13 @@ class LocalExecutionEnvironment(AgentsExecutionEnvironment):
__output: List[Any] = None
__runner: LocalRunner = None
__executed: bool = False
+ __config: AgentConfiguration = AgentConfiguration()
+
+ def get_config(self, path: Optional[str] = None) -> AgentConfiguration:
+ """Get configuration of execution environment."""
+ if path is not None:
+ self.__config.load_from_file(path)
Review Comment:
To ensure consistency in configuration and develop user habits, I believe it
is better to place them under the agent in both local and remote configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
