Izeren commented on code in PR #26950:
URL: https://github.com/apache/flink/pull/26950#discussion_r2307025294
##########
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobWriter.java:
##########
@@ -111,12 +112,29 @@ static <T> Either<SerializedValue<T>, PermanentBlobKey>
offloadWithException(
Preconditions.checkNotNull(serializedValue);
Preconditions.checkNotNull(jobId);
Preconditions.checkNotNull(blobWriter);
+ LOG.info(
+ "Offloading BLOB for job {}, size: {}",
+ jobId,
+ serializedValue.getByteArray().length);
+ final SystemClock systemClock = SystemClock.getInstance();
+ final long offloadStartTs = systemClock.relativeTimeMillis();
try {
final PermanentBlobKey permanentBlobKey =
blobWriter.putPermanent(jobId,
serializedValue.getByteArray());
- return Either.Right(permanentBlobKey);
+ final Either<SerializedValue<T>, PermanentBlobKey> right =
+ Either.Right(permanentBlobKey);
+ LOG.info(
+ "BLOB for job {} with size: {} has been offloaded in {}
millis",
+ jobId,
+ serializedValue.getByteArray().length,
+ systemClock.relativeTimeMillis() - offloadStartTs);
Review Comment:
You are making a good point, my current PR would add 2 INFO logs + modify
existing WARN, while I could add only 1 INFO log + add more info in WARN. I
will update PR to incorporate your suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
