Sxnan commented on code in PR #26951:
URL: https://github.com/apache/flink/pull/26951#discussion_r2317644556
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/metrics/MetricStore.java:
##########
@@ -689,4 +650,57 @@ private static SubtaskMetricStore
unmodifiable(SubtaskMetricStore source) {
unmodifiableMap(source.metrics),
unmodifiableMap(source.attempts));
}
}
+
+ /** Sub-structure containing a snapshot of all jobs in the metric store. */
+ @ThreadSafe
+ public static class MetricStoreJobs {
Review Comment:
Maybe name it `JobMetricStores` or `JobMetricStoresSnapshot`.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobDetailsHandler.java:
##########
@@ -100,7 +102,7 @@ public Collection<ArchivedJson>
archiveJsonWithPath(AccessExecutionGraph graph)
}
private static JobDetailsInfo createJobDetailsInfo(
- AccessExecutionGraph executionGraph, @Nullable MetricFetcher
metricFetcher) {
+ AccessExecutionGraph executionGraph, @Nullable
MetricStore.MetricStoreJobs jobs) {
Review Comment:
The name `jobs` is too general and may be confusing. The `MetricsStoreJobs`
is actually a snapshot of the metrics of all jobs. We may name it `jobMetrics`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
