xintongsong commented on code in PR #126:
URL: https://github.com/apache/flink-agents/pull/126#discussion_r2318455269
##########
python/flink_agents/plan/tests/test_action.py:
##########
@@ -58,14 +60,22 @@ def action() -> Action: # noqa: D103
name="legal",
exec=func,
listen_event_types=[f"{InputEvent.__module__}.{InputEvent.__qualname__}"],
+ params={
Review Comment:
`Action` is not a public api. The question is, do we want to expose the
ability of adding parameters to users. If true, how can user use this feature
via public apis? If not, we should not expose this via runner context, which is
also public api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
