[
https://issues.apache.org/jira/browse/FLINK-38318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Nuyanzin updated FLINK-38318:
------------------------------------
Component/s: API / Python
> Add python autoformatter to pyflink
> ------------------------------------
>
> Key: FLINK-38318
> URL: https://issues.apache.org/jira/browse/FLINK-38318
> Project: Flink
> Issue Type: Bug
> Components: API / Python
> Reporter: Sergey Nuyanzin
> Priority: Major
>
> Currently we have spotless
> however there is also python code and it have some validation for style
> leading to failures, like
> {noformat}
> Sep 03 08:11:52 ./pyflink/table/catalog.py:163:101: E501 line too long (107 >
> 100 characters)
> Sep 03 08:11:52 ./pyflink/table/table_environment.py:624:101: E501 line too
> long (131 > 100 characters)
> Sep 03 08:11:52 ./pyflink/table/table_environment.py:626:101: E501 line too
> long (122 > 100 characters)
> {noformat}
>
> https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=69581&view=logs&j=9cada3cb-c1d3-5621-16da-0f718fb86602&t=0a887b12-e4d0-528d-2191-73222db51fda&l=20115
> And these kind of errors require manual resolution
> For now I see 2 possible improvements
> # Add python autoformatter and allow to use it similar to {{./mvnw
> spotless:apply}}
> # Run style validation before all the tests as for now we have to wait half
> an hour or more for tests and after that the validation might fail like in CI
> example above
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
