yuxiqian commented on code in PR #3776:
URL: https://github.com/apache/flink-cdc/pull/3776#discussion_r2324315988


##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/factory/MySqlDataSourceFactory.java:
##########
@@ -235,6 +236,27 @@ public DataSource createDataSource(Context context) {
             configFactory.chunkKeyColumn(chunkKeyColumnMap);
         }
 
+        String snapshotFilters = config.get(SCAN_SNAPSHOT_FILTERS);
+        if (snapshotFilters != null) {
+            Map<String, String> snapshotFilterMap = new HashMap<>();
+            for (String snapshotFilter : snapshotFilters.split(";")) {
+                String[] splits = snapshotFilter.trim().split(":");

Review Comment:
   I think a better solution to this problem should allow passing nested YAML 
structures (LIST and MAP should be enough) as config option values instead of 
inventing more customized syntaxes, as they're hard to write and parse.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to