GitHub user xintongsong added a comment to the discussion: Vector Store Integration for Flink Agents
@alnzng Thanks for preparing this design doc. In general, the design looks really good to me. There might be some details worth discussion (attribute names, parameters to include, etc.), which don't really affect the overall design and can be discussed during the code review process. For the high level design, I just have a few comments. 1. Do you think we need an abstraction of `EmbeddingModel`, similar to the `ChatModel`? 2. The RAG Agent design looks really nice. I think we might consider making it another built-in agent of the framework, just like ReAct Agent. The user only need to specify the prompt, chat model, embedding model, and vector store, and everything else are ready to use. GitHub link: https://github.com/apache/flink-agents/discussions/143#discussioncomment-14315357 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected]
