liyude-tw commented on code in PR #26809:
URL: https://github.com/apache/flink/pull/26809#discussion_r2328594044
##########
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java:
##########
@@ -110,16 +110,16 @@ public class YarnConfigOptions {
public static final ConfigOption<Long>
APPLICATION_ATTEMPT_FAILURE_VALIDITY_INTERVAL =
key("yarn.application-attempt-failures-validity-interval")
.longType()
- .defaultValue(10000L)
+ .defaultValue(-1L)
Review Comment:
@davidradl Thanks for the feedback
I agree with your suggestion to deprecate the existing config and introduce
a new one. I have updated the code to do the following:
- Add a new ConfigOption with the key
`yarn.application-attempt-failures-global-validity-interval`.
- **Deprecate** the old key
`yarn.application-attempt-failures-validity-interval` using
`withDeprecatedKeys`.
- Update all references in the code to use the new variable name
`APPLICATION_ATTEMPT_FAILURES_GLOBAL_VALIDITY_INTERVAL`.
I have also updated the related documentation to reflect these changes.
Please let me know if this looks good to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
