echauchot commented on code in PR #37:
URL:
https://github.com/apache/flink-connector-cassandra/pull/37#discussion_r2329552936
##########
flink-connector-cassandra/src/test/java/org/apache/flink/connector/cassandra/CassandraTestEnvironment.java:
##########
@@ -118,39 +139,46 @@ public void tearDown() throws Exception {
stopEnv();
}
- private static void addJavaOpts(GenericContainer<?> container, String...
opts) {
- String jvmOpts = container.getEnvMap().getOrDefault("JVM_OPTS", "");
- container.withEnv("JVM_OPTS", jvmOpts + " " + StringUtils.join(opts, "
"));
- }
-
private void startEnv() throws Exception {
// configure container start to wait until cassandra is ready to
receive queries
- cassandraContainer.waitingFor(new CassandraQueryWaitStrategy());
// start with retrials
- cassandraContainer.start();
- cassandraContainer.followOutput(
+ cassandraContainer1.waitingFor(
+ Wait.forLogMessage(".*Startup complete.*", 1)
Review Comment:
Yes, I prefer the standard CassandraQueryWaitStrategy as well and it is
what I did at first but the containers failed to start both. So I opened [this
ticket](https://github.com/testcontainers/testcontainers-java/issues/10372) in
testContainers. “Startup complete” log was what @eddumelendez suggested. But
he also suggested clearing the java opts. So what I can test is just clear the
java opts and still use standard CassandraQueryWaitStrategy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
