wenjin272 commented on PR #107: URL: https://github.com/apache/flink-agents/pull/107#issuecomment-3278370520
Hi, @yanand0909, thanks for your contribution. I see you have updated the pr and address most comments, but I think there may be still some implementation details to be clarified. To show my thought more clearly, I write some code on [https://github.com/wenjin272/flink-agents/tree/mcp-complete](url). The code is based on this pr, and add three commits, which are 1. Refactor the MCPPrompt implementation to align usage with its super class. And the implementation also refers to llama_index BasicMCPClient. 2. Make MCPServer json serializable and threat MCPServer as SerializableResource. Because MCPPrompt and MCPTool both have MCPServer field, and in flink-agents, Prompt and Tool is SerializableResource and should be json serializable, which is the requirement of AgentPlan transfer from Python to Java and from JM to TM. 3. Upgrade minimum python version of flink-agents from 3.9 to 3.10 because MCP python sdk only support python>=3.10. And fix the ruff check error after upgrade. @xintongsong Could you also take a look about my code at your convenience? After we reach a consensus, I think there should also be an example to show how to use a mcp server in agent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
