gustavodemorais commented on code in PR #26966:
URL: https://github.com/apache/flink/pull/26966#discussion_r2344379178
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/logical/FlinkLogicalMultiJoin.java:
##########
@@ -207,7 +211,29 @@ public RelNode convert(final RelNode rel) {
multiJoin.getOuterJoinConditions(),
multiJoin.getJoinTypes(),
multiJoin.getPostJoinFilter(),
- Collections.emptyList());
+ hints);
+ }
+
+ private List<RelHint> normalizeStateTtlHints(final List<RelHint>
originalHints) {
+ final boolean containsValidStateTtlHint =
+ originalHints.stream()
+ .filter(hint ->
hint.hintName.equals(STATE_TTL.getHintName()))
+ .anyMatch(
+ hint ->
+ hint.listOptions.stream()
+ .anyMatch(
+ option ->
+
!option.equals(
+
StateTtlHint
+
.NO_STATE_TTL)));
+
+ if (containsValidStateTtlHint) {
+ return originalHints;
+ } else {
+ return originalHints.stream()
+ .filter(hint ->
!hint.hintName.equals(STATE_TTL.getHintName()))
Review Comment:
It doesn't. Calcite already normalizes hints
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
