davidradl commented on code in PR #26987:
URL: https://github.com/apache/flink/pull/26987#discussion_r2348339060
##########
flink-python/pyflink/table/tests/test_expression.py:
##########
@@ -295,6 +295,12 @@ def test_expressions(self):
self.assertEqual("TO_TIMESTAMP_LTZ('2023-01-01 00:00:00', 'yyyy-MM-dd
HH:mm:ss', 'UTC')",
str(to_timestamp_ltz("2023-01-01 00:00:00",
"yyyy-MM-dd HH:mm:ss", "UTC")))
self.assertEqual("TO_TIMESTAMP_LTZ(123, 0)", str(to_timestamp_ltz(123,
0)))
+ self.assertEqual('TO_TIMESTAMP_LTZ(a)', str(to_timestamp_ltz(expr1))
Review Comment:
I am curious, would these added tests would have failed before the fix? As
the Lit function gets string input - which I would think it could cope with. By
all means leave in these tests, but I think we should have more tests; I
suggest including a test of the reported issue with col() which fails prior to
the fix.
I suggest adding some tests where the function is not successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
