echauchot commented on PR #35:
URL: 
https://github.com/apache/flink-connector-cassandra/pull/35#issuecomment-3293522509

   > Thanks @echauchot . Can you re run the CI again. (I had missed the 
license/notice in the shaded jar, so I corrected it with the last commit.) And 
should i stash now, if you are done with the review?
   
   Done. 
   Yes please squash to the first commit. This commit granularity is fine. For 
later changes to parts of the code we will keep the commit granularity smaller 
for isolation purposes, but for new feature addition 1 commit is good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to