snuyanzin commented on code in PR #26990:
URL: https://github.com/apache/flink/pull/26990#discussion_r2352078985
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/catalog/CatalogPropertiesUtilTest.java:
##########
@@ -114,17 +134,40 @@ public void testCatalogTableSerde() {
List<Index> indexes =
Collections.singletonList(
DefaultIndex.newIndex("f1",
Collections.singletonList("f1")));
- final ResolvedSchema schema =
+ final ResolvedSchema resolvedSchema =
new ResolvedSchema(columns, Collections.emptyList(),
primaryKey, indexes);
- final ResolvedCatalogTable testTable = new
ResolvedCatalogTable(catalogTable, schema);
-
- final Map<String, String> serializedMap =
- CatalogPropertiesUtil.serializeCatalogTable(testTable,
DefaultSqlFactory.INSTANCE);
- final CatalogTable deserializedTable =
- CatalogPropertiesUtil.deserializeCatalogTable(serializedMap);
-
- assertThat(deserializedTable.getUnresolvedSchema().toString())
- .isEqualTo(catalogTable.getUnresolvedSchema().toString());
+ return Stream.of(
+ new ResolvedCatalogTable(
+ CatalogTable.newBuilder()
+ .schema(schema)
+ .comment("some comment")
+ .options(new HashMap<>())
Review Comment:
done for this and other similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
