wenjin272 commented on code in PR #168:
URL: https://github.com/apache/flink-agents/pull/168#discussion_r2354019725
##########
python/flink_agents/api/resource.py:
##########
@@ -35,7 +35,7 @@ class ResourceType(Enum):
EMBEDDING_MODEL_CONNECTION = "embedding_model_connection"
PROMPT = "prompt"
# VECTOR_STORE = "vector_store"
- # MCP_SERVER = "mcp_server"
+ MCP_SERVER = "mcp_server"
Review Comment:
Yes, we should add this in ResourceType.java. Thank you for the reminder.
@xintongsong , the reason we should add is when deserialize the AgentPlan
json created from python in java side. It will reconstruct the resource type
from string value
https://github.com/apache/flink-agents/blob/1e2098c88d7085e0d74072c684b141d3c0230330/plan/src/main/java/org/apache/flink/agents/plan/serializer/ResourceProviderJsonDeserializer.java#L104
But may be we must add comments in `ResourceType.java`, the MCPServer is
only supported in python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
