gyfora commented on code in PR #936: URL: https://github.com/apache/flink-kubernetes-operator/pull/936#discussion_r2354402151
########## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/validation/DefaultAutoscalerValidator.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.autoscaler.validation; + +import org.apache.flink.autoscaler.config.AutoScalerOptions; +import org.apache.flink.autoscaler.utils.CalendarUtils; +import org.apache.flink.configuration.ConfigOption; +import org.apache.flink.configuration.Configuration; + +import java.util.Optional; + +import static org.apache.flink.autoscaler.config.AutoScalerOptions.OBSERVED_SCALABILITY_COEFFICIENT_MIN; +import static org.apache.flink.autoscaler.config.AutoScalerOptions.UTILIZATION_MAX; +import static org.apache.flink.autoscaler.config.AutoScalerOptions.UTILIZATION_MIN; +import static org.apache.flink.autoscaler.config.AutoScalerOptions.UTILIZATION_TARGET; + +/** Default implementation of {@link AutoscalerValidator}. */ +public class DefaultAutoscalerValidator implements AutoscalerValidator { Review Comment: Instead of making this an interface with a default implementation, can we simply make this a regular class and just use it directly? `AutoscalerValidator` that contains the implementation. If later we want to make it pluggable then we can extract the interface but now this is just boilerplate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
