lvyanquan commented on code in PR #3675:
URL: https://github.com/apache/flink-cdc/pull/3675#discussion_r2354391823
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/main/java/org/apache/flink/cdc/connectors/oracle/table/OracleTableSourceFactory.java:
##########
@@ -195,8 +201,12 @@ public Set<ConfigOption<?>> optionalOptions() {
private static final String SCAN_STARTUP_MODE_VALUE_INITIAL = "initial";
private static final String SCAN_STARTUP_MODE_VALUE_SNAPSHOT = "snapshot";
private static final String SCAN_STARTUP_MODE_VALUE_LATEST =
"latest-offset";
+ private static final String SCAN_STARTUP_MODE_VALUE_SPECIFIC_OFFSETS =
"specific-offset";
+ private static final String
SCAN_STARTUP_MODE_VALUE_SPECIFIC_OFFSETS_PREFIX =
+ "scan.startup.specific-offset.";
Review Comment:
Please update related doc for the newly added startup option.
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oracle-cdc/src/main/java/org/apache/flink/cdc/connectors/oracle/table/OracleTableSourceFactory.java:
##########
@@ -195,8 +201,12 @@ public Set<ConfigOption<?>> optionalOptions() {
private static final String SCAN_STARTUP_MODE_VALUE_INITIAL = "initial";
private static final String SCAN_STARTUP_MODE_VALUE_SNAPSHOT = "snapshot";
private static final String SCAN_STARTUP_MODE_VALUE_LATEST =
"latest-offset";
+ private static final String SCAN_STARTUP_MODE_VALUE_SPECIFIC_OFFSETS =
"specific-offset";
+ private static final String
SCAN_STARTUP_MODE_VALUE_SPECIFIC_OFFSETS_PREFIX =
+ "scan.startup.specific-offset.";
Review Comment:
Do we have other kind of offset other than `lsn` in Oracle?
If `lsn` is the only kind of offset, we can upgrade this into a ConfigOption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
