GreatEugenius commented on PR #177: URL: https://github.com/apache/flink-agents/pull/177#issuecomment-3302164184
> LGTM. > > But maybe we can directly remove the `name` field of Resource, I find it may be useless. WDYT @Sxnan . Agreed! The name field in the Resource struct currently serves no practical purpose. While users may need a name to reference a resource, the name field stored within the resource itself has no visible use cases in the current implementation. This could even lead to confusion between the identifier used to retrieve the resource versus the internal field. Removing it would simplify the structure without impacting functionality. Let's proceed with deletion unless there are hidden dependencies we should be aware of. @Sxnan any objections or considerations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
