letaoj commented on code in PR #138:
URL: https://github.com/apache/flink-agents/pull/138#discussion_r2352976072
##########
api/src/main/java/org/apache/flink/agents/api/configuration/AgentConfigOptions.java:
##########
@@ -23,4 +23,8 @@ public class AgentConfigOptions {
/** The config parameter specifies the directory for the FileEvent file. */
public static final ConfigOption<String> BASE_LOG_DIR =
new ConfigOption<>("baseLogDir", String.class, null);
+
+ /** The config parameter specifies the backend for action state store. */
+ public static final ConfigOption<String> ACTION_STATE_STORE_BACKEND =
+ new ConfigOption<>("actionStateStoreBackend", String.class,
"inmemory");
Review Comment:
```
public ConfigOption(String key, Class<T> type, T defaultValue) {
this.key = Objects.requireNonNull(key);
this.type = Objects.requireNonNull(type);
this.defaultValue = defaultValue;
}
```
yeah, the last value is default which is `inmemory`. Do you think I should
make the default null so that when not enabled explicitly, it will disable all
of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
