davidradl commented on code in PR #26999:
URL: https://github.com/apache/flink/pull/26999#discussion_r2359198482
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/AbstractPrometheusReporter.java:
##########
@@ -61,10 +62,13 @@ public abstract class AbstractPrometheusReporter implements
MetricReporter {
@VisibleForTesting static final char SCOPE_SEPARATOR = '_';
@VisibleForTesting static final String SCOPE_PREFIX = "flink" +
SCOPE_SEPARATOR;
+ @VisibleForTesting static final char DEFAULT_SCOPE_SEPARATOR = '.';
private final Map<String, AbstractMap.SimpleImmutableEntry<Collector,
Integer>>
collectorsWithCountByMetricName = new HashMap<>();
+ private final List<String> whiteLists = new ArrayList<>();
Review Comment:
can we avoid the use of whitelists. google results shows The terms "[allow
list](https://www.google.com/search?q=allow+list&rlz=1C5GCCM_en&oq=white+list+acceptable+term&gs_lcrp=EgZjaHJvbWUyBggAEEUYOTIJCAEQIRgKGKABMgkIAhAhGAoYoAEyCQgDECEYChigATIJCAQQIRgKGKAB0gEJMTI1NjhqMGo0qAIAsAIB&sourceid=chrome&ie=UTF-8&mstk=AUtExfDQOQqqY3e-JXRdP9pMOQ4ot1VVxXamXWPgZ0W1bZguXVz_0Z8mApalROrqL-k6PKzWCYAcVyDLUAdhfdcSUpQwr1J8iosoQ2B_6vhNvm5kdICZ3THK9PuhEVR93ZO-zoPb2FkZo_rel_HCyobzlH6l0r9ckZd5fuycUff5eNrFvvXhz-ZCK29HDFzdOErBWrs6CcPvi_bO63vUBHsNNgrSvB8THpYLz6F4tNSHbbj_9hpiY82xF0n7DX1KB1B0UbYn_GKB2GTUhP7P9l1fjner&csui=3&ved=2ahUKEwjYl_yfsOKPAxUh2gIHHYAEAZUQgK4QegQIARAC)"
or "[approved
list](https://www.google.com/search?q=approved+list&rlz=1C5GCCM_en&oq=white+list+acceptable+term&gs_lcrp=EgZjaHJvbWUyBggAEEUYOTIJCAEQIRgKGKABMgkIAhAhGAoYoAEyCQgDECEYChigATIJCAQQIRgKGKAB0gEJMTI1NjhqMGo0qAIAsAIB&sourceid=chrome&ie=UTF-8&mstk=AUtExfDQOQqqY3e-JXRdP9pMOQ4ot1VVxXamXWPgZ0W1bZguXVz_0Z8mApalROrqL-k6PKzWCYAcVyDLUAdhf
dcSUpQwr1J8iosoQ2B_6vhNvm5kdICZ3THK9PuhEVR93ZO-zoPb2FkZo_rel_HCyobzlH6l0r9ckZd5fuycUff5eNrFvvXhz-ZCK29HDFzdOErBWrs6CcPvi_bO63vUBHsNNgrSvB8THpYLz6F4tNSHbbj_9hpiY82xF0n7DX1KB1B0UbYn_GKB2GTUhP7P9l1fjner&csui=3&ved=2ahUKEwjYl_yfsOKPAxUh2gIHHYAEAZUQgK4QegQIARAD)"
are widely considered acceptable alternatives to "whitelist," which can carry
pejorative or exclusionary connotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
