xuyangzhong commented on code in PR #26907:
URL: https://github.com/apache/flink/pull/26907#discussion_r2366542151
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/DeltaJoinTest.scala:
##########
@@ -545,6 +571,39 @@ class DeltaJoinTest extends TableTestBase {
util.verifyRelPlanInsert("insert into tmp_snk select a0, a1 from src1")
}
Review Comment:
The reason for setting `TABLE_EXEC_SINK_UPSERT_MATERIALIZE` to `NONE` is
that, currently, delta join only supports append-only sources. If the entire
pipeline consists of insert-only nodes, sink materializers will not be
generated. The scenarios in which sink materializers are produced involve
aggregates, CDC streams, outer joins and etc, all of which are unsupported by
delta join. I prefer not to have `upsertMaterialize = true` affect tests for
unsupported scenarios. To be on the safe side, I've added
`TABLE_EXEC_SINK_UPSERT_MATERIALIZE = NONE` to all instances in `DeltaJoinTest`
where `upsertMaterialize=[true]` could occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
