snuyanzin commented on code in PR #27018:
URL: https://github.com/apache/flink/pull/27018#discussion_r2367092674
##########
flink-python/pyflink/table/tests/test_pandas_conversion.py:
##########
@@ -171,10 +171,16 @@ def test_to_pandas_for_retract_table(self):
result_pdf =
table.group_by(table.f1).select(table.f2.max.alias('f2')).to_pandas()
import pandas as pd
import numpy as np
- assert_frame_equal(result_pdf, pd.DataFrame(data={'f2':
np.int16([2])}))
+ assert_frame_equal(
+ result_pdf,
+ pd.DataFrame(data={'f2': np.int16([2])}),
+ check_dtype=False)
Review Comment:
Hm... I'm not sure that skipping datatype check is the right approach here...
Why can not we fix the actual issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
