letaoj commented on code in PR #181:
URL: https://github.com/apache/flink-agents/pull/181#discussion_r2369836768
##########
api/src/main/java/org/apache/flink/agents/api/configuration/AgentConfigOptions.java:
##########
@@ -27,4 +27,20 @@ public class AgentConfigOptions {
/** The config parameter specifies the backend for action state store. */
public static final ConfigOption<String> ACTION_STATE_STORE_BACKEND =
new ConfigOption<>("actionStateStoreBackend", String.class, null);
+
+ /** The config parameter specifies the Kafka bootstrap server. */
+ public static final ConfigOption<String> KAFKA_BOOTSTRAP_SERVERS =
+ new ConfigOption<>("kafkaBootstrapServers", String.class,
"localhost:9092");
+
+ /** The config parameter specifies the Kafka topic for action state. */
+ public static final ConfigOption<String> KAFKA_ACTION_STATE_TOPIC =
+ new ConfigOption<>("kafkaActionStateTopic", String.class,
"flink-agents-action-state");
+
+ /** The config parameter sepcifies the number of partitions for the Kafka
action state topic. */
+ public static final ConfigOption<Integer>
KAFKA_ACTION_STATE_TOPIC_NUM_PARTITIONS =
Review Comment:
Because we are auto-creating the state table, it will be better to control
the number of partitions by the framework. The partition will be use perform
the custom partition for kafka (i can probably retrieve it if the topic is
already created)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
