davidradl commented on code in PR #27017:
URL: https://github.com/apache/flink/pull/27017#discussion_r2371551485
##########
flink-core/src/main/java/org/apache/flink/types/variant/BinaryVariantInternalBuilder.java:
##########
@@ -290,7 +290,7 @@ public void appendTimestamp(long microsSinceEpoch) {
public void appendFloat(float f) {
checkCapacity(1 + 4);
writeBuffer[writePos++] = primitiveHeader(FLOAT);
- writeLong(writeBuffer, writePos, Float.floatToIntBits(f), 8);
+ writeLong(writeBuffer, writePos, Float.floatToIntBits(f), 4);
Review Comment:
@JinkunLiu ok thanks for the clarification. It agree it is
strange/misleading that the method is called writeLong, I would have expected
the method to be called `writeInt` as it seems to have nothing to do with Longs
and is writing an Int. Or `writeBytes` to be more generic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
