GreatEugenius commented on code in PR #195:
URL: https://github.com/apache/flink-agents/pull/195#discussion_r2377986841
##########
python/flink_agents/integrations/chat_models/anthropic/anthropic_chat_model.py:
##########
@@ -210,6 +210,12 @@ class AnthropicChatModelSetup(BaseChatModelSetup):
Attributes:
----------
+ connection : str
Review Comment:
Hi @alnzng, thank you very much for your suggestion! You're absolutely right
— using tools like Sphinx can automatically inherit and document attributes
from parent classes, which would avoid duplication and reduce maintenance
overhead. We do plan to adopt such documentation generators in the future.
However, we are currently approaching a release deadline and wanted to
ensure that subclass docstrings remain as self-contained as possible at this
stage. The goal is to make it easier for users to understand all relevant
fields without needing to refer back to the parent class documentation, even if
it means some temporary duplication.
We appreciate your feedback and will definitely keep this in mind for future
improvements!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
