RocMarshal commented on code in PR #26902:
URL: https://github.com/apache/flink/pull/26902#discussion_r2381160581
##########
docs/layouts/shortcodes/generated/history_server_configuration.html:
##########
@@ -30,7 +30,13 @@
<td><h5>historyserver.archive.retained-jobs</h5></td>
<td style="word-wrap: break-word;">-1</td>
<td>Integer</td>
- <td>The maximum number of jobs to retain in each archive directory
defined by `historyserver.archive.fs.dir`. If set to `-1`(default), there is no
limit to the number of archives. If set to `0` or less than `-1` HistoryServer
will throw an <code
class="highlighter-rouge">IllegalConfigurationException</code>. </td>
+ <td>The maximum number of jobs to retain in each archive directory
defined by `historyserver.archive.fs.dir`. When this option is enabled together
with the `historyserver.archive.retained-ttl` option, the job archive will be
removed if its TTL has expired or the retained job count has been reached. If
set to `-1`(default), there is no limit to the number of archives. If set to
`0` or less than `-1` HistoryServer will throw an <code
class="highlighter-rouge">IllegalConfigurationException</code>. Note, when
there are multiple history server instances, please enable the configuration
option like following: <ul><li>Enable this feature in only one HistoryServer
instance to avoid errors caused by multiple instances simultaneously cleaning
up remote files, </li><li>Or you can keep the value of this configuration
consistent across them. </li></ul></td>
Review Comment:
> if we did not specify historyserver.archive.retained-jobs i.e. it was -1,
then the ttl should still take effect.
Yes, you're right. That's what we want.
I have reorganized the possible configuration scenarios and added the scope
and effects of each configuration method.
##########
docs/layouts/shortcodes/generated/history_server_configuration.html:
##########
@@ -30,7 +30,13 @@
<td><h5>historyserver.archive.retained-jobs</h5></td>
<td style="word-wrap: break-word;">-1</td>
<td>Integer</td>
- <td>The maximum number of jobs to retain in each archive directory
defined by `historyserver.archive.fs.dir`. If set to `-1`(default), there is no
limit to the number of archives. If set to `0` or less than `-1` HistoryServer
will throw an <code
class="highlighter-rouge">IllegalConfigurationException</code>. </td>
+ <td>The maximum number of jobs to retain in each archive directory
defined by `historyserver.archive.fs.dir`. When this option is enabled together
with the `historyserver.archive.retained-ttl` option, the job archive will be
removed if its TTL has expired or the retained job count has been reached. If
set to `-1`(default), there is no limit to the number of archives. If set to
`0` or less than `-1` HistoryServer will throw an <code
class="highlighter-rouge">IllegalConfigurationException</code>. Note, when
there are multiple history server instances, please enable the configuration
option like following: <ul><li>Enable this feature in only one HistoryServer
instance to avoid errors caused by multiple instances simultaneously cleaning
up remote files, </li><li>Or you can keep the value of this configuration
consistent across them. </li></ul></td>
Review Comment:
> if we did not specify historyserver.archive.retained-jobs i.e. it was -1,
then the ttl should still take effect.
Yes, you're right. That's what we want.
I have reorganized the possible configuration scenarios and added the scope
and effects of each configuration method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
