liuml07 commented on code in PR #27091:
URL: https://github.com/apache/flink/pull/27091#discussion_r2422370384
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterTest.java:
##########
@@ -1714,7 +1714,7 @@ void testJobFailureWhenGracefulTaskExecutorTermination()
throws Exception {
.equals(event.getName()))
.map(Event::getAttributes)
.map(x -> x.get("newJobStatus")))
- .containsExactly(
+ .containsSubsequence(
Review Comment:
While this test cares more about the `RUNNING → FAILING → FAILED` events
sequence when planned failures happen, I agree it's possible to hide a real
problem in the Flink non-testing code. However, I do not find an easy fix that
only touches the testing code to avoid the race condition. As the
`JobStatusChangeEvent` is only for new job status (code), the initial CREATED
is not expected to be captured here.
Reporting JobStatusChange event seems pretty new. @pnowojski may provide
some ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
